-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android][ios] Upgrade @react-native-community/slider to 4.2.4 #19424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for migrating this package! 🙏
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇 ❌ Error: Changelog entry in wrong CHANGELOG file
Generated by ExpoBot 🤖 against e2662f8 |
Why
close ENG-6538
the latest slider version is v4.3.2, but it is incompatible with reanimated layout animation setup. mainly because it uses the dispatchModern. as we doesn't support fabric on android expo go, it should be fine to not upgrade slider 4.3 which is mainly for fabric support.
How
et uvm -m @react-native-community/slider -c v4.2.4 -p android
et uvm -m @react-native-community/slider -c v4.2.4 -p ios
Test Plan
Checklist
expo prebuild
& EAS Build (eg: updated a module plugin).